gh-149534: Fix unification of defaultdict and frozendict with |#149539
Open
sobolevn wants to merge 1 commit intopython:mainfrom
Open
gh-149534: Fix unification of defaultdict and frozendict with |#149539sobolevn wants to merge 1 commit intopython:mainfrom
defaultdict and frozendict with |#149539sobolevn wants to merge 1 commit intopython:mainfrom
Conversation
sobolevn
added
the
needs backport to 3.15
| with self.assertRaises(TypeError): | ||
| i |= None | ||
|
|
||
| # frozendict |
Member
There was a problem hiding this comment.
Can you also test what frozendict | defaultdict does?
Member
Author
|
@JelleZijlstra you were right, there's a big behavior difference here. >>> from collections import OrderedDict
>>> dict() | OrderedDict()
OrderedDict()
>>> frozendict() | OrderedDict()
frozendict()Since Lines 10531 to 10539 in 354ef33 While it is called for I am not sure that this is a bug, though. It works as expected,, if you know all the little details. But, it might be unexpected for people who just want to swap @vstinner, what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a lot of free time today 😆